Fixes for issue #189 #207
Merged
Fixes for issue #189 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertLRead
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
I have run this on my local machine, and judging from the files changed there is no risk. I am not checking that it matches the Figma appearance; but I assume @agilpatr did that reasonably well. If something needs to be adjusted, we can do it as a separate issue after this is commited. I am a bit uncertain about the style of moving from "div" to "h4" for example. Not that this is wrong, I am just not sure what the style is with Nuxt/Vue/Bootstrap. I am going to merge this, and then send an email to @K42IE about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for styling issue #189. Changed font sizes and lines heights to match Judith and Coco's specifications for the front page, changed spacing on the front page to match the FIGMA.