Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Jump To" scroll section in provenance page #213

Merged
merged 8 commits into from
Jul 29, 2024
Merged

"Jump To" scroll section in provenance page #213

merged 8 commits into from
Jul 29, 2024

Conversation

judithweng
Copy link
Collaborator

Fixes issue #205

@judithweng
Copy link
Collaborator Author

This PR contains the 'Jump To' navigation bar on the left side of the provenance page as well as the dropdown version for mobile users. Currently, when you scroll all the way to the bottom of the page of a device with no children, you will notice that the 'Jump To' nav bar won't have the 'Children Keys' section highlighted (see image below). This is not an error but I am hoping that having a footer might solve this issue. If it is still an issue then, I can look into it.
image

@judithweng judithweng requested a review from K42IE July 23, 2024 20:31
@judithweng judithweng marked this pull request as ready for review July 23, 2024 20:31
Copy link
Collaborator

@RobertLRead RobertLRead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this---it looks good on my desktop. I am concerned about how this would look on a phone, but I will leave that to the designers.

@RobertLRead RobertLRead merged commit 528f716 into main Jul 29, 2024
2 checks passed
@RobertLRead RobertLRead deleted the jump-scroll branch July 29, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create "Jump to Section" And Format the two columns of the History Record Page
2 participants