Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding buttons to pages #253

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Adding buttons to pages #253

merged 9 commits into from
Sep 9, 2024

Conversation

judithweng
Copy link
Collaborator

@judithweng judithweng commented Aug 27, 2024

This is a very large PR that essentially styles the 'Home', 'About Us', 'How it Works' and 'Data & Privacy' pages. The specifics are listed below.

  1. Fixes Implement new custom button component on the homepage #244 : The previous PRs Create 'How it works' page #234 and Style new home page #226 created the 'How it Works' and 'Home' page. However, these did not contain buttons. In this PR, the buttons are added thanks to Ally's button component Created a button component #243.
  2. Fixes About us page #201 : An 'About' page already existed from one of Nora's old PR. This page had most of the contents but did not have the latest design. In this PR, the 'About' page follows the latest Figma design.
  3. Fixes Data & Privacy page #203 : A 'Data & Privacy' page was made in this PR following the latest Figma design.

Things missing or to fix:

  1. The 'Home' page is still not our official home page, but I think once this PR is approved, then we can immediately make this the home page. To visit this 'Home' page, use http://localhost:3000/home

  2. Sometimes when I click 'go back' on my browser, I am unable to see the page (see image below), but it works fine when I reload it. This problem, however, ONLY happens in dev mode (with npm run dev) but not in production mode (npm run preview).

image

@judithweng judithweng marked this pull request as ready for review August 27, 2024 21:56
@vjaqua vjaqua mentioned this pull request Sep 3, 2024
@judithweng judithweng marked this pull request as draft September 5, 2024 20:08
@judithweng judithweng marked this pull request as ready for review September 6, 2024 22:43
Copy link
Collaborator

@RobertLRead RobertLRead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have lighted tested this. I do not fully understand all of it. I approve it.

@RobertLRead RobertLRead merged commit 6a380bd into main Sep 9, 2024
2 checks passed
@RobertLRead RobertLRead deleted the judith-home-buttons branch September 9, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new custom button component on the homepage Data & Privacy page About us page
2 participants