Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Download Image' and Long Words Issue in Provenance Feed #258

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

judithweng
Copy link
Collaborator

@judithweng judithweng commented Aug 30, 2024

This PR fixes #255 and #254.

A single long word is now contained within the gray box and does not 'escape' out of it.

In addition, when a user uploads a file(s), the feed will show a preview and a link that says 'Download Image'. This link was changed to say 'Download File' so that users do not get confused when a PDF or any other non-image file is uploaded. The preview now is only available if users upload an image; they are unable to preview a non-image file. See image below.

image

@judithweng judithweng linked an issue Aug 30, 2024 that may be closed by this pull request
@judithweng judithweng marked this pull request as ready for review August 30, 2024 16:30
@RobertLRead RobertLRead merged commit 555504e into main Sep 9, 2024
2 checks passed
@RobertLRead RobertLRead deleted the judith-prov-feed branch September 9, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Long word in a provenance record [BUG] Change "Download Image" to "Download"
2 participants