Merge pull request #545 from Sharktheone/deps/upgrade-v8

upgrade v8 & fix compile error
gosub-io · Aug 13, 2024 · 9cf4f4d · 9cf4f4d
2 parents bbf7119 + ba2d310
commit 9cf4f4d
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/gosub_v8/Cargo.toml b/crates/gosub_v8/Cargo.toml
@@ -11,6 +11,6 @@ license = "MIT"
 gosub_shared = { path = "../gosub_shared" }
 gosub_webexecutor = { path = "../gosub_webexecutor" }
 thiserror = "1.0.61"
-v8 = "0.98.0"
+v8 = "0.102.0"
 anyhow = "1.0.86"
 serde_json = "1.0.122"
diff --git a/crates/gosub_v8/src/v8/context.rs b/crates/gosub_v8/src/v8/context.rs
@@ -94,7 +94,10 @@ impl<'a> V8Ctx<'a> {
 
         v8_ctx.handle_scope = handle_scope;
 
-        let ctx = v8::Context::new(unsafe { v8_ctx.handle_scope.as_mut() }.get());
+        let ctx = v8::Context::new(
+            unsafe { v8_ctx.handle_scope.as_mut() }.get(),
+            Default::default(),
+        );
 
         let ctx_scope = Box::new(ContextScope::new(
             unsafe { v8_ctx.handle_scope.as_mut() }.get(),

diff --git a/crates/gosub_v8/src/v8/object.rs b/crates/gosub_v8/src/v8/object.rs
@@ -277,7 +277,7 @@ impl<'a> JSObject for V8Object<'a> {
              _name: Local<Name>,
              value: Local<Value>,
              args: PropertyCallbackArguments,
-             _rv: ReturnValue| {
+             _rv: ReturnValue<()>| {
                 let external = match Local::<External>::try_from(args.data()) {
                     Ok(external) => external,
                     Err(e) => {

diff --git a/crates/gosub_webexecutor/Cargo.toml b/crates/gosub_webexecutor/Cargo.toml
@@ -11,7 +11,6 @@ colored = "2.1.0"
 derive_more = "0.99"
 lazy_static = "1.5"
 thiserror = "1.0.61"
-v8 = "0.98.0"
 anyhow = "1.0.86"
 paste = "1.0.15"