New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stop, stop block until really stopped #23

Open

NBR41 wants to merge 1 commit into gosuri:master from NBR41:master

NBR41 commented Nov 17, 2016

Hi,

using your package, i've found that calls to stop in Progress don't stop the go routine of Listen(), becouse the stopChan is set to nil.

reproduced here
https://play.golang.org/p/yDiCsMwWRj

by commenting p.stopChan = nil, it's fixed

I also made call to stop blocking until the go routine is really stopped.


          fix stop, stop block until really stopped

b3599af

Contributor

mgurov commented Nov 20, 2016

Similar to #18 #20 #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet