Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go junitxml: compute per package start times rather than using per execution #406

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zdylag
Copy link

@zdylag zdylag commented May 13, 2024

This can be pretty meaningful if people want to build a timeline of when what test packages were executing. One example use case would be building a trace view ala https://docs.datadoghq.com/tests/setup/junit_xml/?tab=linux.

Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! This fix sounds good

testjson/execution.go Outdated Show resolved Hide resolved
testjson/execution.go Outdated Show resolved Hide resolved
…ecution

This can be pretty meaningful if people want to build a timeline of when
what test packages were executing. One example use case would be building
a trace view ala https://docs.datadoghq.com/tests/setup/junit_xml/?tab=linux.
@zdylag
Copy link
Author

zdylag commented Sep 5, 2024

Hey @dnephin ! Sorry for the super slow turnaround, but I finally addressed your feedback 😅 No rush clearly, but just letting you know it's been updated.

@zdylag zdylag requested a review from dnephin September 17, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants