Fix incorrect minVersion check - Bug here is either the function is misnamed or the logic is inverted #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reads to me that the current running version is at least equal to the provided version in variable 'v'. In it's current form isGoVersionAtLeast will return false when go runtime is go1.23.0 and supplied string is go1.22 (which is what is being tested for now).
I swapped the x,y to match the function name intent. I couldn't find any notes in diff if we wanted to explicitly not support 1.23 and later.
func isGoVersionAtLeast(v string) bool { return goversion.Compare(v, runtime.Version()) < 0 }