Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tolerate run without pass/failed for benchmarks #438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Sep 11, 2024

  1. tolerate run without pass/failed for benchmarks

    Something in Go 1.20 changed so that there is a `run` event for benchmarks. As
    before, there is no `pass` or `failed`. This triggers the "test is running and
    thus must have failed" logic in gotestsum, which causes it to report the
    benchmark as failed.
    
    As this is the behavior of Go (whether it's correct or not...), gotestsum
    should accept such output. To reduce the risk that genuine problems go
    undetected, such incomplete benchmarks get reported when a panic was
    detected (the original motivation for this workaround).
    pohly committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    956ef0e View commit details
    Browse the repository at this point in the history