Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the provider selection. #9

Open
aabizri opened this issue May 10, 2017 · 0 comments
Open

Improve the provider selection. #9

aabizri opened this issue May 10, 2017 · 0 comments

Comments

@aabizri
Copy link
Collaborator

aabizri commented May 10, 2017

The problem

Currently we implement provider selection through the URL only. However this has the downside that for some providers that restrict some endpoints (like SNCF), we can't stop a request before executing it.

The solution

One way we could do this is move the providers info from URLs to a proper Struct, with information about which endpoints are allowed/disallowed, which will be integrated in Session via a map[string]bool (has O(1) complexity) allowing us not to waste bandwidth.

This may also allow us to have the SSL fingerprints public in those structs, though that's a question for another issue.

As always, I'm open to suggestions.

@aabizri aabizri added this to the v1 release milestone May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant