Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYIC-7634: Add new BAV contract test scenario #2701

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AmritSidhu
Copy link
Contributor

@AmritSidhu AmritSidhu commented Nov 14, 2024

Proposed changes

What changed

The BAV CRI can now return a failed VC that does not contain a CI

Issue tracking

Checklists

Environment variables or secrets

  • No environment variables or secrets were added or changed

@AmritSidhu AmritSidhu requested review from a team as code owners November 14, 2024 09:42
@AmritSidhu AmritSidhu force-pushed the pyic-7634-bav branch 6 times, most recently from c7c18ff to d96fd77 Compare November 18, 2024 12:25
Copy link
Contributor

@MikeCollingwood MikeCollingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, might be worth sending the provider the local pact file before, so they can test it before it is pushed to the broker

The BAV CRI can now return a failed VC that does not contain a CI
Copy link
Contributor

@MikeCollingwood MikeCollingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants