Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate libgphoto2/libgphoto2_port/configure.ac into libgphoto2/configure.ac #708

Open
ndim opened this issue Aug 13, 2021 · 3 comments · May be fixed by #731
Open

Integrate libgphoto2/libgphoto2_port/configure.ac into libgphoto2/configure.ac #708

ndim opened this issue Aug 13, 2021 · 3 comments · May be fixed by #731
Assignees
Labels

Comments

@ndim
Copy link
Member

ndim commented Aug 13, 2021

Is your feature request related to a problem? Please describe.
Running configure --help in a libgphoto2 source tree only shows the configure options for libgphoto2, but not for libgphoto2_port. That is confusing, and bad documentaiton.

Describe the solution you'd like
I would like to integrate libgphoto2/libgphoto2_port/configure.ac into libgphoto2/configure.ac so that a single configure --help run shows all configuration options. That also should accelerate the time needed to run autoreconf (by about a factor of 2) and configure for libgphoto2.

Describe alternatives you've considered
Keep explaining libgphoto2_port options to libgphoto2 users, and keep waiting longer for autoreconf and configure to finish.

Additional context
This is completely unrelated to whether the binaries built (libgphoto2.so and libgphoto2_port.so) are two separate ones or one integrated one.

This issue is so that I remember to do this, and so I can collect related comments here.

@ndim ndim added the build label Aug 13, 2021
@ndim ndim self-assigned this Aug 13, 2021
@ndim
Copy link
Member Author

ndim commented Aug 13, 2021

One interesting part will be whether the translations for libgphoto2 and libgphoto2_port can be kept separate as they are right now, even with a single common integrated configure.ac.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 19, 2023

Alternative might be switching to something like Meson build system, which has native support for subprojects. That way you could maintain a clean separation of the libraries while able to pass options to libgphoto2_port.

@ndim
Copy link
Member Author

ndim commented Jan 30, 2024

JFTR, it is possible to keep the libgphoto2 po/ subdir separate from the libgphoto2_port po/ subdir even with a single configure.ac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants