Improve unpack related APIs and their usage #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those functions get passed an offset value into the data buffer. This offset value needed to be updated on the calling side after the call with internal knowledge of what exactly the unpack function itself was doing. Now the offset becomes an in/out parameter and in updated internally. This substantially reduces the complexity of the calling code. Furthermore, the return value is now an error indicator and the array length gets set via a pointer. This further fixes a few places where there was a bug in the bounds checking or no bounds checking at all.
The idea is to remove 'manual' offset adjustments: ``` unsigned offset = 0; unsigned val = dtoh32o(data, offset); // offset is now 4 ``` Also contains some code beautification near the use of dtoh style macros.
|
@msmeissn I have some other changes lined up that depend on / conflict with this PR. Since you merged later PRs already, I assume this one is either too big or otherwise worrisome? Depending on whether you are still considering it or not, I'd either wait or move forward with another PR (removing 7 duplicate |
|
I will take some time to go over it today, as its needs careful review |
|
Thanks! |
|
Thanks for taking the time to review it properly. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details, see the two commit messages.