Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(normalize,ferry,ferry_generator): Add const constructor to visitors #614

Merged

Conversation

ValentinVignal
Copy link
Contributor

This adds a const constructor to the visitors.

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for ferry-gql canceled.

Name Link
🔨 Latest commit e619718
🔍 Latest deploy log https://app.netlify.com/sites/ferry-gql/deploys/671865a5a9e767000864154c

@ValentinVignal
Copy link
Contributor Author

Do I need to make different pull requests for the different packages?

@knaeckeKami
Copy link
Collaborator

Do I need to make different pull requests for the different packages?

for refactors like this I'm ok if it affects multiple packages, just make sure to use conventional commits with the package names so automatic versioning works

@ValentinVignal
Copy link
Contributor Author

for refactors like this I'm ok if it affects multiple packages, just make sure to use conventional commits with the package names so automatic versioning works

Sure let me do that!

@ValentinVignal ValentinVignal force-pushed the Add-const-constructor-to-visitors branch from 7851de0 to e619718 Compare October 23, 2024 02:55
@ValentinVignal ValentinVignal changed the title refactor(normalize): Add const constructor to visitors refactor(normalize,ferry,ferry_generator): Add const constructor to visitors Oct 23, 2024
@ValentinVignal
Copy link
Contributor Author

for refactors like this I'm ok if it affects multiple packages, just make sure to use conventional commits with the package names so automatic versioning works

@knaeckeKami, I updated the commits and the title of the PR. Is it what you were expecting?

@knaeckeKami
Copy link
Collaborator

knaeckeKami commented Oct 23, 2024

Thanks!

@knaeckeKami knaeckeKami merged commit 0ead540 into gql-dart:master Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants