Parse JSON with openjson #662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Build is failing, I wasn't able to run those locally. If someone explains how to do so I am happy to look at the failures. |
|
You should be able to reproduce locally with |
|
@sdeleuze please include snicoll@5ccc75c |
sdeleuze
force-pushed
the
metadata-no-jackson
branch
from
02d2644 to
2589b41
Compare
This PR does that already, pending review from the team. |
|
Looks good to me. |
melix
approved these changes
Jan 6, 2025
dnestoro
force-pushed
the
metadata-no-jackson
branch
from
2589b41 to
d3a6688
Compare
Code originally contributed by @snicoll. This commit upgrades the use of Jackson to plain old JSONObject. This has the advantage of significantly reduce the size of required dependencies, in particular for the graalvm-reachability-metadata module that is meant to be reused externally.
Code originally contributed by @snicoll.
dnestoro
force-pushed
the
metadata-no-jackson
branch
from
d3a6688 to
7a516f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code originally contributed by @snicoll.
This commit upgrades the use of Jackson to plain old JSONObject. This has the advantage of significantly reduce the size of required dependencies, in particular for the
graalvm-reachability-metadatamodule that is meant to be reused externally.https://github.com/openjson/openjson repository is using an Apache 2 license like Jackson. I guess
THIRD_PARTY_LICENSES.txtshould be updated, but I will let the GraalVM team doing that in case that involves checks on Oracle side.Please wait for a +1 from @aclement or @mminella to merge this PR.