Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pagination to trash page #1494

Merged
merged 6 commits into from
Oct 17, 2024
Merged

feat: add pagination to trash page #1494

merged 6 commits into from
Oct 17, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Oct 2, 2024

Add pagination to recycled items. Remove filter and ordering options for simplification.

close #1493

@pyphilia pyphilia self-assigned this Oct 2, 2024
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, it looks good to me! I just let you some comments and suggestions, I'm of course open to the discussion 🫠

cypress/e2e/item/trash/viewTrash.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/trash/viewTrash.cy.ts Outdated Show resolved Hide resolved
cypress/support/server.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/pages/RecycledItemsScreen.tsx Show resolved Hide resolved
src/components/pages/RecycledItemsScreen.tsx Outdated Show resolved Hide resolved
src/components/pages/RecycledItemsScreen.tsx Outdated Show resolved Hide resolved
src/components/pages/RecycledItemsScreen.tsx Show resolved Hide resolved
@pyphilia pyphilia requested a review from ReidyT October 16, 2024 10:19
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes, LGTM ⛳️

src/components/pages/RecycledItemsScreen.tsx Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 16, 2024

@pyphilia pyphilia added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit c3c5701 Oct 17, 2024
4 checks passed
@spaenleh spaenleh deleted the 1493-recycle-pagination branch October 18, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paginate recycle bin
2 participants