Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use react hook form for base item form #1529

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

pyphilia
Copy link
Contributor

ref #1522

@pyphilia pyphilia self-assigned this Oct 18, 2024
Copy link

sonarcloud bot commented Oct 18, 2024

Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels very weird to use react-hook-form like this. This is only a transition state right ? Otherwise if we plan on keeping nested structures we should invest in using other methods from react-hook-form like the contexts and useController hook.

@pyphilia
Copy link
Contributor Author

Yes it's a transitional state, in the end we should remove the useEffect and watch.

@pyphilia pyphilia added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit ce88fea Oct 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants