Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix copy modal #604

Merged
merged 3 commits into from
Apr 28, 2024
Merged

fix: fix copy modal #604

merged 3 commits into from
Apr 28, 2024

Conversation

pyphilia
Copy link
Contributor

Enable back copy button, using the new item selection modal.

@pyphilia pyphilia self-assigned this Apr 24, 2024
@pyphilia pyphilia linked an issue Apr 24, 2024 that may be closed by this pull request
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you for the changes, just a few tweaks and we are good to go !

cypress/support/server.ts Outdated Show resolved Hide resolved
cypress/support/server.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/collection/CopyButton.tsx Outdated Show resolved Hide resolved
src/components/collection/copyModal/RootNavigationTree.tsx Outdated Show resolved Hide resolved
src/components/collection/copyModal/RootNavigationTree.tsx Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue Apr 28, 2024
Merged via the queue into main with commit 1ddd45d Apr 28, 2024
6 checks passed
@spaenleh spaenleh deleted the 602-copy-fix branch July 24, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy is broken
3 participants