Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecate updating any member #925

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix: deprecate updating any member #925

merged 1 commit into from
Oct 7, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Sep 20, 2024 •
edited
Loading

In this PR:

  • deprecate updating any member

@spaenleh spaenleh self-assigned this Sep 20, 2024
@spaenleh spaenleh added the chore Generic task or chore label Sep 20, 2024
ReidyT
ReidyT previously requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, it looks good to me 😄. I just let one question.

src/member/api.ts Outdated Show resolved Hide resolved
pyphilia
pyphilia requested changes Oct 1, 2024
View reviewed changes
src/hooks/mention.test.ts Outdated Show resolved Hide resolved
src/member/api.ts Outdated Show resolved Hide resolved
@spaenleh
Copy link
Member Author

spaenleh commented Oct 7, 2024

@pyphilia @ReidyT I have updated this PR to only deprecate the editMember hook. The other changes will be implemented in a different PR

@renovate @spaenleh
fix: deprecate useEditMember in favor of useEditCurrentMember
78aecb2 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pyphilia
pyphilia approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚒

@spaenleh spaenleh dismissed ReidyT’s stale review October 7, 2024 12:46

Changes applied

@spaenleh spaenleh added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 71ac265 Oct 7, 2024
3 checks passed
@graasper graasper mentioned this pull request Oct 7, 2024
Merged
@spaenleh spaenleh deleted the deprecate-update-any-member branch October 7, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@spaenleh spaenleh

Labels
chore Generic task or chore v4.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaenleh @pyphilia @ReidyT