Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lifecycle on pod_template #1673

Closed
jianpingzhangBill opened this issue Sep 12, 2024 · 2 comments · Fixed by #1774
Closed

add lifecycle on pod_template #1673

jianpingzhangBill opened this issue Sep 12, 2024 · 2 comments · Fixed by #1774
Labels
enhancement New feature or request

Comments

@jianpingzhangBill
Copy link

Request

We running alloy in daemonset to collect pod logs.
We use AWS spot node, it often was removed. But the alloy pods recycled faster then other pods, it will cause some log didn't send to loki.

Can you help add lifecycle and terminationGracePeriodSeconds to pod_template?

lifecycle:
  preStop:
    exec:
      command: ["sleep", "30"]

Use case

Can you help add lifecycle and terminationGracePeriodSeconds to pod_template?

terminationGracePeriodSeconds: 60
lifecycle:
  preStop:
    exec:
      command: ["sleep", "30"]
@jianpingzhangBill jianpingzhangBill added the enhancement New feature or request label Sep 12, 2024
@etiennep
Copy link
Contributor

This is a duplicate of #1140

@etiennep
Copy link
Contributor

Here's a PR that adds these features: #1774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants