Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows_exporter to 0.28.2 #1628

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Sep 6, 2024

PR Description

As as announced earlier, windows_exporter releases are smaller and released more often to gain feedback.

Which issue(s) this PR fixes

Notes to the Reviewer

As discussed with @mattdurham I implement a shim for prometheus-community/windows_exporter#1585


However, 0.28 brings also some breaking changes in term of the metrics. In case of Grafana Alloy want to deliver a 100% full stable API in terms of metrics, a compatibility layer should be introduced.

Ref: prometheus-community/windows_exporter#1597

Before:

windows_cpu_info{architecture="9",description="AMD64 Family 23 Model 49 Stepping 0",device_id="CPU0",family="107",l2_cache_size="32768",l3_cache_size="262144",name="AMD EPYC 7702P 64-Core Processor"} 1

After:

# HELP windows_cpu_info Labelled CPU information as provided by Win32_Processor
# TYPE windows_cpu_info gauge
windows_cpu_info{architecture="9",description="AMD64 Family 25 Model 33 Stepping 2",device_id="CPU0",family="107",name="AMD Ryzen 9 5900X 12-Core Processor"} 1
# HELP windows_cpu_info_core Number of cores per CPU
# TYPE windows_cpu_info_core gauge
windows_cpu_info_core{device_id="CPU0"} 12
# HELP windows_cpu_info_enabled_core Number of enabled cores per CPU
# TYPE windows_cpu_info_enabled_core gauge
windows_cpu_info_enabled_core{device_id="CPU0"} 12
# HELP windows_cpu_info_l2_cache_size Size of L2 cache per CPU
# TYPE windows_cpu_info_l2_cache_size gauge
windows_cpu_info_l2_cache_size{device_id="CPU0"} 6144
# HELP windows_cpu_info_l3_cache_size Size of L3 cache per CPU
# TYPE windows_cpu_info_l3_cache_size gauge
windows_cpu_info_l3_cache_size{device_id="CPU0"} 65536
# HELP windows_cpu_info_logical_processor Number of logical processors per CPU
# TYPE windows_cpu_info_logical_processor gauge
windows_cpu_info_logical_processor{device_id="CPU0"} 24
# HELP windows_cpu_info_thread Number of threads per CPU
# TYPE windows_cpu_info_thread gauge
windows_cpu_info_thread{device_id="CPU0"} 24

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@jkroepke jkroepke force-pushed the windows/0.28 branch 4 times, most recently from f85aaaf to f563584 Compare September 6, 2024 21:12
@jkroepke jkroepke changed the title Upgrade windows_exporter to 0.28.1 Upgrade windows_exporter to 0.28.2 Sep 28, 2024
@jkroepke
Copy link
Contributor Author

0.28.2 includes the bug fix from @erikbaranowski (prometheus-community/windows_exporter#1647)

@jkroepke jkroepke changed the title Upgrade windows_exporter to 0.28.2 Update windows_exporter to 0.28.2 Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant