Network wal pr #1717
Merged
Network wal pr #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildum
reviewed
Sep 24, 2024
wildum
reviewed
Sep 25, 2024
|
|
||
| // By default each sample only has a histogram, float histogram or sample. | ||
| if cap(ts.Histograms) == 0 { | ||
| ts.Histograms = make([]prompb.Histogram, 1) |
There was a problem hiding this comment.
Suggested change
| ts.Histograms = make([]prompb.Histogram, 1) | |
| ts.Histograms = make([]prompb.Histogram, 0, 1) |
setting the capacity to 1 but the length to 0
There was a problem hiding this comment.
I think functionally this is less ideal, since I would need to use append semantics. There will only ever be 0 or 1 record here.
| if tsBuf.Histograms.FloatHistogram != nil { | ||
| ts.Histograms = ts.Histograms[:1] | ||
| ts.Histograms[0] = tsBuf.Histograms.FloatHistogram.ToPromFloatHistogram() | ||
| } |
There was a problem hiding this comment.
could both cases above simply be appends and the if below could be removed?
There was a problem hiding this comment.
Let me think on this.
thampiotr
reviewed
Sep 26, 2024
Co-authored-by: William Dumont <william.dumont@grafana.com>
Co-authored-by: Piotr <17101802+thampiotr@users.noreply.github.com>
|
Going to merge this and move on to the next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the network items for the new wal. There are some similarities with the old wal, buildWriteRequest and queuing by hash. I have e2e tests that arent shown here, will see if I can distill them to more specific tests but figure we can go ahead and get started looking at the code.