feat(helm): add lifecycle hooks to alloy container #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Sep 26, 2024
etiennep
force-pushed
the
issue-1140
branch
from
f695de7
to
4fbc87b
Compare
|
This seems reasonable but looping in @petewall for any thoughts. |
petewall
approved these changes
Oct 1, 2024
| @@ -183,6 +191,9 @@ controller: | |||
| # -- Configures the DNS policy for the pod. https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy | |||
| dnsPolicy: ClusterFirst | |||
|
|
|||
| # -- Termination grace period in seconds for the Grafana Alloy pods. | |||
| terminationGracePeriodSeconds: null | |||
There was a problem hiding this comment.
should this have a default value? 0?
There was a problem hiding this comment.
According to Kubernetes documentation, the default is 30s. https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/
I will add a note to the comment.
Left a few comments. All in all, looks good to me. |
|
@clayton-cornell for review of docs. |
|
Seeing some helm linting errors. |
|
I think the linting issues should be fixed now @mattdurham Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Fixes #1140
Fixes #1673
Adds lifecycle hooks to the alloy container to allow graceful target de-registration when using with AWS LoadBalancer Controller ingress.
Notes to the Reviewer
PR Checklist