Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the release steps for "Cherry Pick Commits" and "Update Version in Code" #1783

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Sep 27, 2024

Fixing a few issues with the release docs:

  • The example PRs used to point to the Agent.
  • It wasn't very clear what the VERSION file should point to.
  • There is a "Test Release" step which is a bit ambiguios. I think we should remove it and replace it with a CI check.
  • Combining the "Cherry Pick Commits" and "Update Version in Code" steps into one

I find it confusing to have "Cherry Pick Commits" and "Update Version in Code" as two separate steps. It's more efficient (and less confusing) to explain those things in the same step. It also makes the instructions less verbose.

@ptodev ptodev requested a review from a team as a code owner September 27, 2024 17:28
@ptodev ptodev merged commit da5b131 into main Oct 7, 2024
18 checks passed
@ptodev ptodev deleted the ptodev/update-release-instructions branch October 7, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants