-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for x scope org id header in loki source api #1805
Add support for x scope org id header in loki source api #1805
Conversation
I also added tests :) |
internal/component/loki/source/api/internal/lokipush/push_api_server.go
Outdated
Show resolved
Hide resolved
Can we add documentation to the |
@mattdurham do you want me to document the use of the header? Sure I will do that tomorrow at the latest |
Yes, maybe something like we did with scrape https://grafana.com/docs/alloy/latest/reference/components/prometheus/prometheus.scrape/#technical-details @clayton-cornell would be the expert on how this should be organized. |
Lets keep it simple. If it's a technical description of how things work and what to expect... then following the prometheus.scrape example should work. I'll review and if there's structural changes we can either do it in this PR or merge this one and I'll rework in a new (whichever is easiest). |
@clayton-cornell Could you check if the documentation is alright? |
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the docs are OK for this PR.
I will open up an issue on the layout and structure of the Technical details section. I think it's at the wrong level in the topic hierarchy... here and in prometheus.scrape
. Instead of blocking this PR for the doc fixes, let's merge and I'll fix things in a separate doc-only PR.
Thanks for the help :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Description
This pull request introduces a middleware for extracting tenant headers in the loki PushAPIServer to improve tenant context handling.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist