Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location of loki.secretfilter in changelog #1807

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Oct 2, 2024

When #1593 was merged, it added the changelog entry to the RC, even though the change is not on the release branch. I suppose this happened during a git rebase. I edited this out of the release announcement just now.

This PR fixes the changelog so that we can announce the component in the next release.

@ptodev ptodev requested a review from a team as a code owner October 2, 2024 12:50
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this

Copy link
Contributor

@romain-gaillard romain-gaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry about that 😅

@ptodev ptodev merged commit 67409b5 into main Oct 2, 2024
18 checks passed
@ptodev ptodev deleted the ptodev/fix-changelog branch October 2, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants