From b0af58ae68e05ee9e0b5ac4835fb1fa01fbfd2ea Mon Sep 17 00:00:00 2001
From: Piotr <17101802+thampiotr@users.noreply.github.com>
Date: Thu, 3 Oct 2024 15:47:48 +0100
Subject: [PATCH] Fix OTEL alerts query

---
 operations/alloy-mixin/alerts/opentelemetry.libsonnet | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/operations/alloy-mixin/alerts/opentelemetry.libsonnet b/operations/alloy-mixin/alerts/opentelemetry.libsonnet
index 0150ea593..48338477c 100644
--- a/operations/alloy-mixin/alerts/opentelemetry.libsonnet
+++ b/operations/alloy-mixin/alerts/opentelemetry.libsonnet
@@ -4,13 +4,13 @@ local alert = import './utils/alert.jsonnet';
   local successRateQuery(enableK8sCluster, failed, success) =
         local sumBy = if enableK8sCluster then "cluster, namespace, job" else "job";
         |||
-          (1 - sum by (%s) (
-                  rate(%s{}[1m])
+          (1 - (
+                  sum by (%s) (rate(%s{}[1m]))
                   /
-                  (rate(%s{}[1m]) + rate(%s{}[1m]))
+                  sum by (%s) (rate(%s{}[1m]) + rate(%s{}[1m]))
                )
           ) < 0.95
-        ||| % [sumBy, failed, failed, success],
+        ||| % [sumBy, failed, sumBy, failed, success],
 
   newOpenTelemetryAlertsGroup(enableK8sCluster=true):
     alert.newGroup(