Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component #1823

Open
wants to merge 34 commits into
base: dev.new-wal
Choose a base branch
from
Open

Component #1823

wants to merge 34 commits into from
+2,197 −67

Conversation

mattdurham
Copy link
Collaborator

@mattdurham mattdurham commented Oct 3, 2024 •
edited
Loading

This is the last PR, aside from the merge to main. This ties everything together and exposes the component. Most of this are very expansive tests. I am likely to change the metrics in subsequent PRs so dont get to in detail about them.

Things to do that I will do after this large merge and create tickets for each.

  • Add support for TLS
  • Rethink the metrics and the approach.
  • Add metadata support, this requires exposing additional properties on the scrape itself.
  • Add hook to not use labelstore if not running any remote_write components.

clayton-cornell
clayton-cornell reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First high level pass of the docs. I'll go through again once the ToDos are added

docs/sources/reference/components/prometheus/prometheus.remote.queue.md Outdated Show resolved Hide resolved
docs/sources/reference/components/prometheus/prometheus.remote.queue.md Outdated Show resolved Hide resolved
docs/sources/reference/components/prometheus/prometheus.remote.queue.md Outdated Show resolved Hide resolved
docs/sources/reference/components/prometheus/prometheus.remote.queue.md Outdated Show resolved Hide resolved
docs/sources/reference/components/prometheus/prometheus.remote.queue.md Outdated Show resolved Hide resolved
docs/sources/reference/components/prometheus/prometheus.remote.queue.md Outdated Show resolved Hide resolved
docs/sources/reference/components/prometheus/prometheus.remote.queue.md Outdated Show resolved Hide resolved
@mattdurham mattdurham marked this pull request as draft October 4, 2024 03:10
mattdurham and others added 15 commits October 4, 2024 08:55
@mattdurham @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.remote…
e06efff 
….queue.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@mattdurham @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.remote…
992c703 
….queue.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@mattdurham @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.remote…
0546707 
….queue.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@mattdurham @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.remote…
e75e34f 
….queue.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@mattdurham @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.remote…
0ea1f71 
….queue.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@mattdurham @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.remote…
9a90c2b 
….queue.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@mattdurham @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.remote…
f04edb4 
….queue.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@mattdurham
Changes and testing.
0d99288
@mattdurham
Update docs.
ed64bc3
@mattdurham
Update docs.
98bc887
@mattdurham
Fix race conditions in unit tests.
2e32ce6
@mattdurham
Tweaking unit tests.
e1aaa9f
@mattdurham
lower threshold more.
38b15a1
@mattdurham
lower threshold more.
6f9a820
@mattdurham
Fix deadlock in manager tests.
c78ea1d
@mattdurham mattdurham marked this pull request as ready for review October 8, 2024 20:52
@mattdurham mattdurham changed the title WIP: Component Component Oct 8, 2024
mattdurham and others added 6 commits October 9, 2024 08:27
@mattdurham @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.remote…
3bb04d4 
….queue.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@mattdurham @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.remote…
6713554 
….queue.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@mattdurham @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.remote…
d5568d9 
….queue.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@mattdurham @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.remote…
d8cd012 
….queue.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@mattdurham @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.remote…
42fbdd9 
….queue.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@mattdurham @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.remote…
d5eb26e 
….queue.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell
clayton-cornell reviewed Oct 9, 2024
View reviewed changes
docs/sources/reference/components/prometheus/prometheus.remote.queue.md
`prometheus.remote.queue` will retry sending data if the following errors or HTTP status codes are returned:

* Network errors.
* HTTP 429 error.s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* HTTP 429 error.s
* HTTP 429 errors.

Ooops.. transposed the full stop and the last letter in the suggestion, this fixes it.

clayton-cornell
clayton-cornell approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayton-cornell clayton-cornell clayton-cornell approved these changes

Assignees

@ptodev ptodev

@thampiotr thampiotr

@wildum wildum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattdurham @clayton-cornell @ptodev @thampiotr @wildum