[faro collector] add missing struct fields so that payload.meta.browser fields are not lost #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
elee1766
changed the title
elee1766
changed the title
elee1766
changed the title
|
i've modified the test payload to include some values and added them to the expected test result. i dont think i have to modify any config adapters or documentation? if i do please let me know |
|
@t00mas do you have some context for this PR? |
|
No context, but LGTM I'd like to have an issue created, so I can reference that in other components too, please. |
wildum
reviewed
Oct 4, 2024
| @@ -50,6 +50,7 @@ Main (unreleased) | |||
|
|
|||
| - Fix issue where `loki.source.kubernetes` took into account all labels, instead of specific logs labels. Resulting in duplication. (@mattdurham) | |||
|
|
|||
| - Fix an issue where some `faro.receiver` would drop multiple fields defined in `payload.meta.browser`, as fields were defined in the struct | |||
There was a problem hiding this comment.
nit: you can add your github @ if you want credit for it
|
hi. sorry the context is i wanted the fields so i opened a PR. i opened a basic issue. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
a few fields are missing in the struct which is used to read the meta.browser object that faro sends, which results in that information being lost. https://github.com/grafana/faro-web-sdk/blob/v1.10.2/packages/core/src/metas/types.ts#L60-L70
Which issue(s) this PR fixes
fixes #1832
Notes to the Reviewer
i did not do the work for properly parsing
NavigatorUABrandVersion[] | string, since it's more work, and i mostly really just want viewportWidth and viewportHeight. since that field is already being ignored right now, it should be safe to not do until maybe someone else who needs it can add it.PR Checklist