Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DisplayVersion to Windows UninstallKey #1847

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add DisplayVersion to Windows UninstallKey #1847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c0ed89
Add DisplayVersion to Windows UninstallKey
charlygott Oct 8, 2024
b5f1c2d
Update CHANGELOG
charlygott Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ Main (unreleased)

- Fix an issue where some `faro.receiver` would drop multiple fields defined in `payload.meta.browser`, as fields were defined in the struct.

- Added the `DisplayVersion` value to the Windows NSIS installer to simplify patch management for enterprise environments. (@charlygott)

### Bugfixes

- Fixed a bug in `import.git` which caused a `"non-fast-forward update"` error message. (@ptodev)
Expand Down
1 change: 1 addition & 0 deletions packaging/windows/install_script.nsis
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ Section "install"
# the current installed version.
!define UNINSTALLKEY "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}"
WriteRegStr HKLM "${UNINSTALLKEY}" "DisplayName" '${APPNAME} ${VERSION}'
WriteRegStr HKLM "${UNINSTALLKEY}" "DisplayVersion" '${VERSION}'
WriteRegStr HKLM "${UNINSTALLKEY}" "UninstallString" '"$INSTDIR\uninstall.exe"'
WriteRegStr HKLM "${UNINSTALLKEY}" "QuietUninstallString" '"$INSTDIR\uninstall.exe" /S'
WriteRegStr HKLM "${UNINSTALLKEY}" "InstallLocation" '"$INSTDIR"'
Expand Down