[pyroscope.java] Clean-up JFR files left behind by previous instances of alloy to reduce risk of filling up disk when alloy's in crash loop #2317
+41
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
swar8080
force-pushed
the
cleanup-old-jfr-files
branch
from
e2a36a1 to
fe958a5
Compare
…mize risk of filling up disk when alloy's in a crash loop
swar8080
force-pushed
the
cleanup-old-jfr-files
branch
from
fe958a5 to
037e9bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Cleans-up unused JFR files that were accumulating on profiling targets' filesystem by previously terminated instances of alloy. This helps reduce the risk of files piling up if alloy is constantly restarting, like if kubernetes memory limits are too low.
Which issue(s) this PR fixes
Fixes #1960
Notes to the Reviewer
I tested this manually on our EKS cluster with amd64 linux nodes. I both manually created
asproffiles and used some left behind by terminated alloy pods to test that this new code is executed once during start-up.I couldn't find any unit or integration tests for this component so let me know if there's suggestions for further testing.
PR Checklist