Fix EOF issue when building on drone in windows. #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng mixed up line endings. Changing them to normal RUN fixes the problem and allows you to build on windows that passes to a linux container.
|
I'm worried about increased number of layers this adds which will make the build image even bigger than normal; each RUN creates a new layer. Can this be combined into a single run command using && to separate them? |
|
Sure, changed to && style |
rfratto
approved these changes
May 6, 2024
rfratto
added
the
backport-to-agent:no
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
When using drone on windows the code must pass through a few layers til it gets to the linux build container, the EOF command is not compatible with windows and will cause issues. In my case it either only partially executed the command or ignored it. That then led to corepack not found since it never installed nodejs.
By using separate RUN lines the behavior is the same when calling drone on linux and windows even when they are both using a linux docker container under the hood.