Fix missing service info (#1444)

grafana · Dec 12, 2024 · 064fb93 · 064fb93
1 parent 59313dd
commit 064fb93
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/pkg/internal/kube/store.go b/pkg/internal/kube/store.go
@@ -339,16 +339,17 @@ func (s *Store) ServiceNameNamespaceForIP(ip string) (string, string) {
 		s.access.RUnlock()
 		return serviceInfo.Name, serviceInfo.Namespace
 	}
+	s.access.RUnlock()
+
+	s.access.Lock()
+	defer s.access.Unlock()
 
 	name, namespace := "", ""
 	if om, ok := s.objectMetaByIP[ip]; ok {
 		name, namespace = s.serviceNameNamespaceForMetadata(om)
 	}
-	s.access.RUnlock()
 
-	s.access.Lock()
 	s.otelServiceInfoByIP[ip] = OTelServiceNamePair{Name: name, Namespace: namespace}
-	s.access.Unlock()
 
 	return name, namespace
 }

diff --git a/pkg/kubecache/meta/informers.go b/pkg/kubecache/meta/informers.go
@@ -52,7 +52,7 @@ func (inf *Informers) Subscribe(observer Observer) {
 		for _, service := range inf.services.GetStore().List() {
 			// ignore headless services from being added
 			if headlessService(service.(*indexableEntity).EncodedMeta) {
-				return
+				continue
 			}
 			if err := observer.On(&informer.Event{
 				Type:     informer.EventType_CREATED,