Skip to content

Commit

Permalink
fixed few more vale complaints
Browse files Browse the repository at this point in the history
  • Loading branch information
@mariomac
mariomac committed Mar 7, 2024
1 parent bca44ed commit 1865dad
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/sources/network/config.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,12 @@ cache before being flushed for its later export.
| `direction` | `BEYLA_NETWORK_DIRECTION` | string | `both` |

Allows selecting which flows to trace according to its direction in the interface
where they are captured from. Accepted values are `ingress`, `egress` or `both` (default).
where they are captured from. Accepted values are `ingress`, `egress`, or `both` (default).

It's important to emphasize that here, ingress or egress are not related to incoming/outgoing

Check warning on line 169 in docs/sources/network/config.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[Grafana.GoogleOxfordComma] Use the Oxford comma in 'It's important to emphasize that here, ingress or'.

For more information, refer to https://developers.google.com/style/commas.

If the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.GoogleOxfordComma%20%3A%20%3CISSUE%3E).

If you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).

Raw Output:
{"message": "[Grafana.GoogleOxfordComma] Use the Oxford comma in 'It's important to emphasize that here, ingress or'.\n\nFor more information, refer to https://developers.google.com/style/commas.\n\nIf the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.GoogleOxfordComma%20%3A%20%3CISSUE%3E).\n\nIf you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).", "location": {"path": "docs/sources/network/config.md", "range": {"start": {"line": 169, "column": 1}}}, "severity": "WARNING"}
traffic from outside the node or the cluster, but the network interface. This means that
the same network packet could be seen as "ingress" in a virtual network device and as "egress" in the
backing phisical network interface.
backing physical network interface.

| YAML | Environment variable | Type | Default |
|------------|--------------------------|---------|----------------|
Expand Down
2 changes: 1 addition & 1 deletion docs/sources/network/quickstart.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
title: Beyla Network Metrics Quickstart
title: Beyla network metrics quickstart
menuTitle: Quickstart
description: A quickstart guide to produce Network Metrics from Grafana Beyla
weight: 2
Expand Down

0 comments on commit 1865dad

Please sign in to comment.