Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken instrumentation for google.golang.org/grpc 1.61 #608

Closed
mariomac opened this issue Feb 8, 2024 · 3 comments
Closed

Broken instrumentation for google.golang.org/grpc 1.61 #608

mariomac opened this issue Feb 8, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@mariomac
Copy link
Contributor

mariomac commented Feb 8, 2024

Concretely, the fields: localAddr and remoteAddr have been removed from google.golang.org/grpc/internal/transport/http2Server in some version of GRPC > 1.58.3 and <= 1.61.0.

This would make gRPC instrumentation stop working for services with updated libraries.

@mariomac mariomac added the bug Something isn't working label Feb 8, 2024
@mariomac
Copy link
Contributor Author

mariomac commented Feb 8, 2024

It seems already addressed but after updating, our integration tests failed. Let's see if we need to fix the tests or there is a bug.

@mariomac mariomac changed the title Removed fields from google.golang.org/grpc 1.61 Broken instrumentation for google.golang.org/grpc 1.61 Feb 8, 2024
@mariomac
Copy link
Contributor Author

mariomac commented Feb 8, 2024

Our integration tests seem to fail for GRPC >= 1.61:

        	Error Trace:	/Users/mmacias/code/beyla/test/integration/traces_test.go:205
        	            				/Users/mmacias/code/beyla/test/integration/traces_test.go:170
        	Error:      	Should be empty, but was The following tags did not match:
        	            		tag values do not match:
        	            			want: {Key:server.port Type:int64 Value:50051}
        	            			got:  {Key:server.port Type:int64 Value:0}

@mariomac
Copy link
Contributor Author

mariomac commented Feb 8, 2024

Fixed in #609

@mariomac mariomac closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant