-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: set up network metrics for Asserts #1007
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
==========================================
- Coverage 80.17% 80.16% -0.01%
==========================================
Files 137 137
Lines 10930 10930
==========================================
- Hits 8763 8762 -1
- Misses 1685 1686 +1
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The test failures need a merge with main, the new jaeger release yesterday is causing us to fail to push traces. |
24a7087
to
9bb78f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
I have a minor correction, but I'll let @gouthamve to give the final approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit. But LGTM!
Lets
docs/sources/network/asserts.md
Outdated
1. An application to auto-instrument with Beyla. | ||
1. A Linux environment that supports eBPF kernel modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say these are optional tbh.
31d4ba9
to
c4966ca
Compare
@mariomac I forgot to tag for backports, what's the process again to manually port the change to latest? |
Co-authored-by: Mario Macias <mario.macias@grafana.com> Co-authored-by: Goutham Veeramachaneni <goutham@grafana.com> (cherry picked from commit c5730ef)
Co-authored-by: Mario Macias <mario.macias@grafana.com> Co-authored-by: Goutham Veeramachaneni <goutham@grafana.com> (cherry picked from commit c5730ef)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-1007-to-release-1.4 origin/release-1.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x c5730ef6f72e2c4c6adaba538b9b162bd92eb516 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-1007-to-release-1.4
# Create the PR body template
PR_BODY=$(gh pr view 1007 --json body --template 'Backport c5730ef6f72e2c4c6adaba538b9b162bd92eb516 from #1007{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release-1.4] Documentation: set up network metrics for Asserts' --body-file - --label 'documentation' --label 'type/docs' --label 'backport' --base release-1.4 --milestone release-1.4 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-1007-to-release-1.4
# Create a pull request where the `base` branch is `release-1.4` and the `compare`/`head` branch is `backport-1007-to-release-1.4`.
# Remove the local backport branch
git switch main
git branch -D backport-1007-to-release-1.4 |
Adds documentation to set up Asserts network.