Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OTEL expirer and hide it from docs #1066

Merged
merged 1 commit into from
Jul 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions docs/sources/configure/options.md
Original file line number Diff line number Diff line change
Expand Up @@ -833,16 +833,6 @@ attacks. This option should be used only for testing and development purposes.

Configures the intervening time between exports.


| YAML | Environment variable | Type | Default |
|-------|--------------------------|----------|---------|
| `ttl` | `BEYLA_OTEL_METRICS_TTL` | Duration | `5m` |

The group of attributes for a metric instance is not reported anymore if the time since
the last update is greater than this Time-To-Leave (TTL) value.

The purpose of this value is to avoid reporting indefinitely finished application instances.

| YAML | Environment variable | Type | Default |
|------------|-------------------------------|-----------------|------------------------------|
| `features` | `BEYLA_OTEL_METRICS_FEATURES` | list of strings | `["application"]` |
Expand Down
4 changes: 3 additions & 1 deletion pkg/beyla/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,9 @@ var DefaultConfig = Config{
Instrumentations: []string{
instrumentations.InstrumentationALL,
},
TTL: defaultMetricsTTL,
// TODO: keep OTEL expiration disabled by default until we address
// this issue: https://github.com/grafana/beyla/issues/1065
TTL: 100 * 365 * 24 * time.Hour,
},
Traces: otel.TracesConfig{
Protocol: otel.ProtocolUnset,
Expand Down
1 change: 1 addition & 0 deletions pkg/beyla/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ ebpf:
functions:
- FooBar
otel_metrics_export:
ttl: 5m
endpoint: localhost:3030
buckets:
duration_histogram: [0, 1, 2]
Expand Down
Loading