Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for checking git-lfs files #1194

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Add workflow for checking git-lfs files #1194

merged 1 commit into from
Sep 24, 2024

Conversation

rafaelroquetto
Copy link
Contributor

@rafaelroquetto rafaelroquetto commented Sep 23, 2024

Adds a check that prevents files that should have been tracked by git-lfs to be directly committed to the git repository.

Tested for failure: https://github.com/grafana/beyla/actions/runs/10999538512/job/30539903906
Tested for success: https://github.com/grafana/beyla/actions/runs/10999512344/job/30539820365

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.09%. Comparing base (c3901b2) to head (46f49ca).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
+ Coverage   81.03%   81.09%   +0.06%     
==========================================
  Files         136      136              
  Lines       11501    11501              
==========================================
+ Hits         9320     9327       +7     
+ Misses       1647     1641       -6     
+ Partials      534      533       -1     
Flag Coverage Δ
integration-test 56.99% <ø> (+0.01%) ⬆️
k8s-integration-test 58.74% <ø> (+0.06%) ⬆️
oats-test 35.81% <ø> (ø)
unittests 53.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice!

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@rafaelroquetto rafaelroquetto merged commit bd8952e into main Sep 24, 2024
10 checks passed
@rafaelroquetto rafaelroquetto deleted the lfs_workflow branch September 24, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants