Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to measure latency of k8s informer #1200

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Sep 25, 2024

This can be helpful to measure latency of k8s informers in Beyla and count the total requests to k8s API.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 81.53846% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.12%. Comparing base (fb456f1) to head (83108e0).

Files with missing lines Patch % Lines
pkg/internal/imetrics/imetrics.go 54.54% 5 Missing ⚠️
pkg/internal/imetrics/iprom.go 88.46% 3 Missing ⚠️
pkg/internal/transform/kube/db.go 76.92% 3 Missing ⚠️
pkg/internal/appolly/appolly.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1200      +/-   ##
==========================================
+ Coverage   81.07%   81.12%   +0.05%     
==========================================
  Files         136      136              
  Lines       11501    11551      +50     
==========================================
+ Hits         9324     9371      +47     
- Misses       1643     1647       +4     
+ Partials      534      533       -1     
Flag Coverage Δ
integration-test 57.13% <36.92%> (+0.17%) ⬆️
k8s-integration-test 58.99% <81.53%> (+0.23%) ⬆️
oats-test 35.66% <6.15%> (-0.16%) ⬇️
unittests 53.12% <12.30%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marctc marctc merged commit 6960d77 into main Sep 26, 2024
10 checks passed
@marctc marctc deleted the add_metrics_informer branch September 26, 2024 12:45
marctc added a commit that referenced this pull request Oct 1, 2024
marctc added a commit that referenced this pull request Oct 7, 2024
marctc added a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants