Support DaemonSet and StatefulSet in discovery and decoration #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
===========================================
+ Coverage 45.02% 79.24% +34.22%
===========================================
Files 67 70 +3
Lines 5664 5889 +225
===========================================
+ Hits 2550 4667 +2117
+ Misses 2964 999 -1965
- Partials 150 223 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mariomac
added a commit
to mariomac/beyla
that referenced
this pull request
Jan 25, 2024
…a#571) * Integration tests for daemonset and statefulset metadata decoration * Support replicaset and daemonset decoration and discovery
This was referenced Jan 25, 2024
mariomac
added a commit
that referenced
this pull request
Jan 25, 2024
…ckport) (#572) * Support DaemonSet and StatefulSet in discovery and decoration (#571) * Integration tests for daemonset and statefulset metadata decoration * Support replicaset and daemonset decoration and discovery * Prometheus exporter: add k8s_replicaset_name, k8s_daemonset_name and k8s_statefulset_name attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing documentation (in another PR).
Addresses bug #562
We were assuming that instrumented applications were only deployed as Deployments, while they can be plain replicasets, or daemonsets or statefulsets.
This adds the following metadata fields:
k8s.statefulset.name,k8s.daemonset.nameand the following discovery arguments:k8s_owner_name,k8s_statefulset_name,k8s_daemonset_name(to be documented).