Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DaemonSet and StatefulSet in discovery and decoration (1.2 backport) #572

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Jan 25, 2024

Backport of PRs #571 and #574

…a#571)

* Integration tests for daemonset and statefulset metadata decoration

* Support replicaset and daemonset decoration and discovery
@codecov-commenter
Copy link

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (129a6d8) 79.17% compared to head (d60f25a) 79.00%.

Files Patch % Lines
pkg/internal/kube/owner.go 79.48% 8 Missing ⚠️
pkg/internal/discover/watcher_kube.go 71.42% 5 Missing and 1 partial ⚠️
pkg/internal/transform/k8s.go 81.25% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.2     #572      +/-   ##
===============================================
- Coverage        79.17%   79.00%   -0.18%     
===============================================
  Files               69       70       +1     
  Lines             5830     5877      +47     
===============================================
+ Hits              4616     4643      +27     
- Misses             990     1011      +21     
+ Partials           224      223       -1     
Flag Coverage Δ
integration-test 68.49% <53.84%> (-0.31%) ⬇️
unittests 45.02% <67.03%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 24c2493 into grafana:release-1.2 Jan 25, 2024
4 checks passed
@mariomac mariomac deleted the k8s-backport-12 branch January 25, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants