Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus exporter: add k8s_replicaset_name, k8s_daemonset_name and k8s_statefulset_name attributes #574

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

mariomac
Copy link
Contributor

The previous PR did not update the prometheus exporter.

Now, many labels might be empty. We will let the intermediate prometheus scraper (e.g. the Grafana Agent) to filter these properties.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch!

@mariomac mariomac merged commit cb287ee into grafana:main Jan 25, 2024
4 checks passed
@mariomac mariomac deleted the k8s-prom branch January 25, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants