Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing BEYLA_SYSTEM_WIDE advicing from error logs #577

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

mariomac
Copy link
Contributor

I realized that so many users were using this undocumented environment variable because it often appears in the first error message they see.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b9bbd7) 79.26% compared to head (6644c96) 44.78%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #577       +/-   ##
===========================================
- Coverage   79.26%   44.78%   -34.48%     
===========================================
  Files          70       68        -2     
  Lines        5907     5729      -178     
===========================================
- Hits         4682     2566     -2116     
- Misses       1001     3008     +2007     
+ Partials      224      155       -69     
Flag Coverage Δ
integration-test ?
unittests 44.78% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit fb4bd1a into grafana:main Jan 29, 2024
4 checks passed
@mariomac mariomac deleted the rm-syswide branch January 29, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants