Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish-technical-documentation-release workflow for tag events #583

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Jan 28, 2024

Fix typo in variable from docs-target output and checkout correct branch.

The release branches are named release-X.Y.
The docs-target action outputs vX.Y.

The step now uses the output (fixing the typo in the GitHub variable name) as an environment variable so Bash can strip the v prefix.

The release branches are named `release-X.Y`.
The `docs-target` action outputs `vX.Y`.

The step now uses the output (fixing the typo in the GitHub variable name) as an environment variable so Bash can strip the `v` prefix.

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry changed the title Fix typo in variable from docs-target output and checkout correct branch Fix publish-technical-documentation-release workflow for tag events Jan 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b9bbd7) 79.26% compared to head (563d2f7) 79.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
- Coverage   79.26%   79.19%   -0.07%     
==========================================
  Files          70       70              
  Lines        5907     5907              
==========================================
- Hits         4682     4678       -4     
- Misses       1001     1004       +3     
- Partials      224      225       +1     
Flag Coverage Δ
integration-test 68.74% <ø> (-0.07%) ⬇️
unittests 44.91% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Thanks for fixing.

@jdbaldry jdbaldry merged commit 6152438 into main Jan 29, 2024
4 checks passed
@jdbaldry jdbaldry deleted the jdb/2024-01-fix-release-workflow branch January 29, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants