Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate context in http2 #585

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Propagate context in http2 #585

merged 7 commits into from
Jan 30, 2024

Conversation

grcevski
Copy link
Contributor

This PR adds context propagation with our http2 instrumentation.

@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (9553916) 79.32% compared to head (842f935) 44.80%.
Report is 9 commits behind head on main.

Files Patch % Lines
pkg/internal/ebpf/nethttp/nethttp.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #585       +/-   ##
===========================================
- Coverage   79.32%   44.80%   -34.52%     
===========================================
  Files          69       68        -1     
  Lines        5856     5745      -111     
===========================================
- Hits         4645     2574     -2071     
- Misses        988     3016     +2028     
+ Partials      223      155       -68     
Flag Coverage Δ
integration-test ?
unittests 44.80% <0.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mazing!

@grcevski grcevski merged commit 0da32eb into grafana:main Jan 30, 2024
4 checks passed
@grcevski
Copy link
Contributor Author

Thanks Mario!

@grcevski grcevski deleted the propagate_http2 branch January 30, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants