Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc update for readOnlyRootFilesystem #594

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

esara
Copy link
Contributor

@esara esara commented Feb 1, 2024

doc update for readOnlyRootFilesystem for emptydir for /var/run/beyla
address #593

…n/beyla

Signed-off-by: Endre Sara <endresara@gmail.com>
Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0da32eb) 79.85% compared to head (8014fdc) 79.68%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
- Coverage   79.85%   79.68%   -0.17%     
==========================================
  Files          70       70              
  Lines        5917     5933      +16     
==========================================
+ Hits         4725     4728       +3     
- Misses        971      980       +9     
- Partials      221      225       +4     
Flag Coverage Δ
integration-test 69.31% <ø> (-0.14%) ⬇️
unittests 44.67% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!!!

@grcevski grcevski merged commit 4a06207 into grafana:main Feb 1, 2024
5 checks passed
@esara esara deleted the emptydir branch February 1, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants