From 6cda8fad1bdb832bd6cc507bf46ed7b015004817 Mon Sep 17 00:00:00 2001 From: Nikola Grcevski Date: Thu, 1 Feb 2024 10:37:15 -0500 Subject: [PATCH 1/2] Disable http2 context prop test --- test/integration/http2go_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/integration/http2go_test.go b/test/integration/http2go_test.go index 3ff0cefe8..1f572d137 100644 --- a/test/integration/http2go_test.go +++ b/test/integration/http2go_test.go @@ -169,7 +169,8 @@ func TestHTTP2Go(t *testing.T) { testREDMetricsForHTTP2Library(t, "/pingrt", "http2-go") }) - if !lockdown { + // Seems flaky, we need to look into this. + if !lockdown && false { t.Run("Go RED metrics: http2 context propagation ", func(t *testing.T) { testNestedHTTP2Traces(t, "ping") testNestedHTTP2Traces(t, "pingdo") From 99d6895900d6e36b20435b0839365346dee03878 Mon Sep 17 00:00:00 2001 From: Nikola Grcevski Date: Thu, 1 Feb 2024 11:35:29 -0500 Subject: [PATCH 2/2] Use t.skip instead --- test/integration/http2go_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/integration/http2go_test.go b/test/integration/http2go_test.go index 1f572d137..92796fe9a 100644 --- a/test/integration/http2go_test.go +++ b/test/integration/http2go_test.go @@ -93,6 +93,7 @@ func testREDMetricsForHTTP2Library(t *testing.T, route, svcNs string) { } func testNestedHTTP2Traces(t *testing.T, url string) { + t.Skip("seems flaky, we need to look into this") var traceID string var trace jaeger.Trace @@ -170,7 +171,7 @@ func TestHTTP2Go(t *testing.T) { }) // Seems flaky, we need to look into this. - if !lockdown && false { + if !lockdown { t.Run("Go RED metrics: http2 context propagation ", func(t *testing.T) { testNestedHTTP2Traces(t, "ping") testNestedHTTP2Traces(t, "pingdo")