Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added http route to client attributes #597

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

vgnanasekaran
Copy link
Contributor

Added http route to client attributes

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d71758) 79.79% compared to head (b5a8eac) 79.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
+ Coverage   79.79%   79.83%   +0.04%     
==========================================
  Files          70       70              
  Lines        5933     5936       +3     
==========================================
+ Hits         4734     4739       +5     
+ Misses        976      974       -2     
  Partials      223      223              
Flag Coverage Δ
integration-test 69.48% <100.00%> (+0.06%) ⬆️
unittests 44.76% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grcevski grcevski merged commit 447c8b9 into grafana:main Feb 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants