Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed gRPC 1.61 offsets and updated go.mod versions #609

Merged
merged 8 commits into from
Feb 9, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Feb 8, 2024

A couple of the dependencies had vulnerabilities.

Also I wanted to get the latest version of the OTEL SDK, for improved Prometheus support.

I also found and fix a bug in the way we handled the gRPC removed address fields (see comment below)

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41c0b76) 79.88% compared to head (247d365) 69.27%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #609       +/-   ##
===========================================
- Coverage   79.88%   69.27%   -10.61%     
===========================================
  Files          70       67        -3     
  Lines        5947     5830      -117     
===========================================
- Hits         4751     4039      -712     
- Misses        974     1510      +536     
- Partials      222      281       +59     
Flag Coverage Δ
integration-test 69.27% <100.00%> (-0.18%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac changed the title updated go.mod versions Fixed gRPC 1.61 offsets and updated go.mod versions Feb 8, 2024
@mariomac mariomac added the bug Something isn't working label Feb 8, 2024
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grcevski
Copy link
Contributor

grcevski commented Feb 8, 2024

I've seen this before, depending on the distro we build on sometimes there are these verifier errors. I can't see them anymore after I've recompiled. I'm investigating more.

@grcevski
Copy link
Contributor

grcevski commented Feb 8, 2024

OK, so as I expected, compiling on Ubuntu worked, but I reproduced the issue by compiling on Fedora. I believe I fixed the issue by using this new helper I added some time ago bpf_clamp_umax, which makes the correct value limiting assembly unrelated to the compiler version. If this passes, I'll pull one more time, recompile on Ubuntu, just to make sure all combinations pass.

@mariomac mariomac merged commit 19b91e8 into grafana:main Feb 9, 2024
4 checks passed
@mariomac
Copy link
Contributor Author

mariomac commented Feb 9, 2024

Thanks @nikola! I will change the base image of the docker generator, then.

@mariomac mariomac deleted the update-gomod branch February 9, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants