Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generator-build-image makefile task #624

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Feb 14, 2024

It failed after looking for some version numbers in an nonexistent go.mod file.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8be0bc8) 79.42% compared to head (48f5903) 79.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
- Coverage   79.42%   79.02%   -0.40%     
==========================================
  Files          70       70              
  Lines        6027     6027              
==========================================
- Hits         4787     4763      -24     
- Misses       1013     1030      +17     
- Partials      227      234       +7     
Flag Coverage Δ
integration-test 68.77% <ø> (-0.36%) ⬇️
unittests 44.33% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 6cb90b3 into grafana:main Feb 14, 2024
4 checks passed
@mariomac mariomac deleted the fix-generator-build branch February 14, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants